Messages in this thread | | | Date | Wed, 13 Jun 2012 11:03:42 +0100 | From | Mark Brown <> | Subject | Re: [PATCH RFT 3/4] regulator: wm831x-dcdc: Convert wm831x_buckv_ops to set_voltage_sel and map_voltage |
| |
On Tue, Jun 12, 2012 at 10:23:09AM +0800, Axel Lin wrote: > Signed-off-by: Axel Lin <axel.lin@gmail.com>
This patch is way more invasive than it needs to be (and therefore hard to check) because
> - if (dcdc->dvs_gpio && dcdc->on_vsel == vsel) > + if (dcdc->dvs_gpio && dcdc->on_vsel == selector)
you've replaced vsel with selector throughout the code. [unhandled content-type:application/pgp-signature] | |