Messages in this thread | | | Date | Wed, 09 May 2012 09:41:12 +0800 | From | Alex Shi <> | Subject | Re: [PATCH v3 4/7] x86/tlb: add tlb flush all factor for specific CPUs |
| |
On 05/08/2012 11:18 PM, H. Peter Anvin wrote:
> On 05/08/2012 07:03 AM, Alex Shi wrote: >> >> - if (!cpu_has_invlpg || vma->vm_flags & VM_HUGETLB) { >> + if (!cpu_has_invlpg || vma->vm_flags & VM_HUGETLB >> + || !tlb_flushall_factor) { > > OK nevermind on the division by zero, but this yet another test being > performed. > > If nothing else you could fold these tests and make tlb_flushall_factor > zero if !cpu_has_invlpg.
Yes, should be.
> > -hpa >
| |