lkml.org 
[lkml]   [2012]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 4/7] x86/tlb: add tlb flush all factor for specific CPUs
On 05/08/2012 11:18 PM, H. Peter Anvin wrote:

> On 05/08/2012 07:03 AM, Alex Shi wrote:
>>
>> - if (!cpu_has_invlpg || vma->vm_flags & VM_HUGETLB) {
>> + if (!cpu_has_invlpg || vma->vm_flags & VM_HUGETLB
>> + || !tlb_flushall_factor) {
>
> OK nevermind on the division by zero, but this yet another test being
> performed.
>
> If nothing else you could fold these tests and make tlb_flushall_factor
> zero if !cpu_has_invlpg.


Yes, should be.

>
> -hpa
>




\
 
 \ /
  Last update: 2012-05-09 04:01    [W:0.032 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site