lkml.org 
[lkml]   [2012]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V3] block: Mitigate lock unbalance caused by lock switching
    On 05/28/2012 07:39 PM, Asias He wrote:

    <snip>

    > @@ -440,6 +435,11 @@ void blk_cleanup_queue(struct request_queue *q)
    > del_timer_sync(&q->backing_dev_info.laptop_mode_wb_timer);
    > blk_sync_queue(q);
    >
    > + spin_lock_irq(lock);
    > + if (q->queue_lock != &q->__queue_lock)
    > + q->queue_lock = &q->__queue_lock;
    > + spin_unlock_irq(lock);
    > +

    Isn't the 'if' clause superfluous ? You could just do the assignment, e.g.,

    + spin_lock_irq(lock);
    + q->queue_lock = &q->__queue_lock;
    + spin_unlock_irq(lock);

    rtg
    --
    Tim Gardner tim.gardner@canonical.com


    \
     
     \ /
      Last update: 2012-05-29 16:21    [W:0.025 / U:0.008 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site