lkml.org 
[lkml]   [2012]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] block: Mitigate lock unbalance caused by lock disconnect
    On Mon, May 28, 2012 at 10:20:03AM +0800, Asias He wrote:
    > Commit 777eb1bf15b8532c396821774bf6451e563438f5 disconnects externally
    > supplied queue_lock before blk_drain_queue(). This would introduce lock
    > unbalance because theads which have taken the external lock might unlock
    > the internal lock in the during the queue drain.
    >
    > This patch mitigate this by disconnecting the lock after the queue
    > draining since queue draining makes a lot of request_queue users go
    > away.

    Can you please point out how the code is broken and that the code is
    still broken after the patch but somewhat less likely to actually
    fail?

    Thanks.

    --
    tejun


    \
     
     \ /
      Last update: 2012-05-28 13:01    [W:0.032 / U:1.016 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site