[lkml]   [2012]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH] video: fb_defio.c: local functions should not be exposed globally
    Functions not referenced outside of a source file should be marked
    static to prevent them from being exposed globally.

    Quiets the sparse warning:

    warning: symbol 'fb_deferred_io_page' was not declared. Should it be static?

    Signed-off-by: H Hartley Sweeten <>
    Cc: Jaya Kumar <>
    Cc: Florian Tobias Schandinat <>


    diff --git a/drivers/video/fb_defio.c b/drivers/video/fb_defio.c
    index 070f26f..1ddeb11 100644
    --- a/drivers/video/fb_defio.c
    +++ b/drivers/video/fb_defio.c
    @@ -23,7 +23,7 @@
    #include <linux/rmap.h>
    #include <linux/pagemap.h>

    -struct page *fb_deferred_io_page(struct fb_info *info, unsigned long offs)
    +static struct page *fb_deferred_io_page(struct fb_info *info, unsigned long offs)
    void *screen_base = (void __force *) info->screen_base;
    struct page *page;

     \ /
      Last update: 2012-05-03 02:41    [W:0.021 / U:11.208 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site