Messages in this thread Patch in this message | | | From | H Hartley Sweeten <> | Subject | [PATCH] video: fb_defio.c: local functions should not be exposed globally | Date | Wed, 2 May 2012 17:23:40 -0700 |
| |
Functions not referenced outside of a source file should be marked static to prevent them from being exposed globally.
Quiets the sparse warning:
warning: symbol 'fb_deferred_io_page' was not declared. Should it be static?
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Jaya Kumar <jayalk@intworks.biz> Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
---
diff --git a/drivers/video/fb_defio.c b/drivers/video/fb_defio.c index 070f26f..1ddeb11 100644 --- a/drivers/video/fb_defio.c +++ b/drivers/video/fb_defio.c @@ -23,7 +23,7 @@ #include <linux/rmap.h> #include <linux/pagemap.h> -struct page *fb_deferred_io_page(struct fb_info *info, unsigned long offs) +static struct page *fb_deferred_io_page(struct fb_info *info, unsigned long offs) { void *screen_base = (void __force *) info->screen_base; struct page *page;
| |