lkml.org 
[lkml]   [2012]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2] sysfs: Removed dup_name entirely in sysfs_rename
    Date
    Since no one using "dup_name", removed it completely in sysfs_rename, 

    Signed-off-by: Sasikantha babu <sasikanth.v19@gmail.com>
    ---
    fs/sysfs/dir.c | 6 ++----
    1 files changed, 2 insertions(+), 4 deletions(-)

    diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c
    index 35a36d3..24fa995 100644
    --- a/fs/sysfs/dir.c
    +++ b/fs/sysfs/dir.c
    @@ -858,7 +858,6 @@ int sysfs_rename(struct sysfs_dirent *sd,
    struct sysfs_dirent *new_parent_sd, const void *new_ns,
    const char *new_name)
    {
    - const char *dup_name = NULL;
    int error;

    mutex_lock(&sysfs_mutex);
    @@ -875,11 +874,11 @@ int sysfs_rename(struct sysfs_dirent *sd,
    /* rename sysfs_dirent */
    if (strcmp(sd->s_name, new_name) != 0) {
    error = -ENOMEM;
    - new_name = dup_name = kstrdup(new_name, GFP_KERNEL);
    + new_name = kstrdup(new_name, GFP_KERNEL);
    if (!new_name)
    goto out;

    - dup_name = sd->s_name;
    + kfree(sd->s_name);
    sd->s_name = new_name;
    }

    @@ -895,7 +894,6 @@ int sysfs_rename(struct sysfs_dirent *sd,
    error = 0;
    out:
    mutex_unlock(&sysfs_mutex);
    - kfree(dup_name);
    return error;
    }

    --
    1.7.3.4


    \
     
     \ /
      Last update: 2012-04-30 12:21    [W:0.027 / U:0.140 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site