| Date | Tue, 3 Apr 2012 13:47:05 +0200 | From | Jesper Nilsson <> | Subject | Re: [PATCH 02/69] TTY: crisv10, initialize tty_port |
| |
On Mon, Apr 02, 2012 at 01:53:46PM +0200, Jiri Slaby wrote: > The tty_port used in the driver is left uninitialized. Add the > initialization there. > > Signed-off-by: Jiri Slaby <jslaby@suse.cz> > Cc: Mikael Starvik <starvik@axis.com>
Looks good!
Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>
> Cc: linux-cris-kernel@axis.com > --- > drivers/tty/serial/crisv10.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/tty/serial/crisv10.c b/drivers/tty/serial/crisv10.c > index 004ee2e..80b6b1b 100644 > --- a/drivers/tty/serial/crisv10.c > +++ b/drivers/tty/serial/crisv10.c > @@ -4462,6 +4462,7 @@ static int __init rs_init(void) > info->enabled = 0; > } > } > + tty_port_init(&info->port); > info->uses_dma_in = 0; > info->uses_dma_out = 0; > info->line = i; > -- > 1.7.9.2 > /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com
|