Messages in this thread | | | Date | Mon, 02 Apr 2012 17:45:18 -0500 | From | Dave Kleikamp <> | Subject | Re: [RFC PATCH v2 18/21] ext4: add support for read_iter and write_iter |
| |
On 04/02/2012 01:42 PM, Ted Ts'o wrote: > On Fri, Mar 30, 2012 at 10:43:45AM -0500, Dave Kleikamp wrote: >> use the generic .read_iter and .write_iter functions > > Potentially silly question --- why not use NULL pointer to mean > generic_file_read_iter and generic_file_write_iter? Then you won't > have to patch a bunch of file systems to add the generic .read_iter > and .write_iter?
I'm not very confident that generic_file_read_iter and generic_file_write_iter will work for every filesystem that I haven't yet touched. It should work if they use generic_aio_read and _write, but some have their own versions of those.
Shaggy
| |