[lkml]   [2012]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [RFC PATCH v2 18/21] ext4: add support for read_iter and write_iter
    On 04/02/2012 05:45 PM, Dave Kleikamp wrote:
    > On 04/02/2012 01:42 PM, Ted Ts'o wrote:
    >> On Fri, Mar 30, 2012 at 10:43:45AM -0500, Dave Kleikamp wrote:
    >>> use the generic .read_iter and .write_iter functions
    >> Potentially silly question --- why not use NULL pointer to mean
    >> generic_file_read_iter and generic_file_write_iter? Then you won't
    >> have to patch a bunch of file systems to add the generic .read_iter
    >> and .write_iter?
    > I'm not very confident that generic_file_read_iter and
    > generic_file_write_iter will work for every filesystem that I haven't
    > yet touched. It should work if they use generic_aio_read and _write, but
    > some have their own versions of those.

    In fact, I just realized a big oversight on my part in that I have ext4
    calling generic_file_write_iter(), when in fact, it should be doing the
    equivalent of ext4_file_write(). If been chasing a bug assuming that
    ext4 called generic_aio_write(). Sometimes I miss the obvious.

    > Shaggy

     \ /
      Last update: 2012-04-03 02:13    [W:0.020 / U:59.160 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site