lkml.org 
[lkml]   [2012]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -next] wireless: TI wlxxx depends on MAC80211
From
Date
Hi Randy,

On Mon, 2012-04-16 at 12:51 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> wl12xx build fails with many undefined symbol errors when MAC80211
> and CFG80211 are not enabled, so make WLCORE and WL12XX depend
> on MAC80211 (which already depends on CFG80211).
>
> Here are a few of the many build errors:
>

[...]

> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> Cc: Luciano Coelho <coelho@ti.com>
> Cc: linux-wireless@vger.kernel.org
> Cc: "John W. Linville" <linville@tuxdriver.com>
> ---

Thanks for the patch!


> --- linux-next-20120416.orig/drivers/net/wireless/ti/wl12xx/Kconfig
> +++ linux-next-20120416/drivers/net/wireless/ti/wl12xx/Kconfig
> @@ -1,5 +1,6 @@
> config WL12XX
> tristate "TI wl12xx support"
> + depends on MAC80211
> select WLCORE

Do we really need this one? wl12xx selects WLCORE which in turn depends
on MAC80211 (with your change below). Maybe we don't need this?


> ---help---
> This module adds support for wireless adapters based on TI wl1271,
> --- linux-next-20120416.orig/drivers/net/wireless/ti/wlcore/Kconfig
> +++ linux-next-20120416/drivers/net/wireless/ti/wlcore/Kconfig
> @@ -1,6 +1,6 @@
> config WLCORE
> tristate "TI wlcore support"
> - depends on WL_TI && GENERIC_HARDIRQS
> + depends on WL_TI && GENERIC_HARDIRQS && MAC80211
> depends on INET
> select FW_LOADER
> ---help---

--
Cheers,
Luca.



\
 
 \ /
  Last update: 2012-04-17 07:33    [from the cache]
©2003-2011 Jasper Spaans