lkml.org 
[lkml]   [2012]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -next] mtd: fix sbc2_flash build when PCI is not enabled
    On 04/16/2012 03:20 PM, Paul Gortmaker wrote:

    > On Mon, Apr 16, 2012 at 3:50 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
    >> From: Randy Dunlap <rdunlap@xenotime.net>
    >>
    >> sbc2_flash.c is a PCI driver, but its build fails when CONFIG_PCI
    >
    > Minor nit -- above line and subject reference sbc2, when fail comes
    > from scb2 source module.

    Ack. I noticed later that I had botched that.

    Thanks.

    > Paul.
    > --
    >
    >> is not enabled, so make it depend on PCI.
    >>
    >> drivers/mtd/maps/scb2_flash.c:237:1: warning: data definition has no type or storage class
    >> drivers/mtd/maps/scb2_flash.c:237:1: warning: type defaults to 'int' in declaration of 'module_pci_driver'
    >> drivers/mtd/maps/scb2_flash.c:237:1: warning: parameter names (without types) in function declaration
    >>
    >> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
    >> Cc: David Woodhouse <dwmw2@infradead.org>
    >> Cc: linux-mtd@lists.infradead.org
    >> ---
    >> drivers/mtd/maps/Kconfig | 2 +-
    >> 1 file changed, 1 insertion(+), 1 deletion(-)
    >>
    >> --- linux-next-20120416.orig/drivers/mtd/maps/Kconfig
    >> +++ linux-next-20120416/drivers/mtd/maps/Kconfig
    >> @@ -224,7 +224,7 @@ config MTD_CK804XROM
    >>
    >> config MTD_SCB2_FLASH
    >> tristate "BIOS flash chip on Intel SCB2 boards"
    >> - depends on X86 && MTD_JEDECPROBE
    >> + depends on X86 && MTD_JEDECPROBE && PCI
    >> help
    >> Support for treating the BIOS flash chip on Intel SCB2 boards
    >> as an MTD device - with this you can reprogram your BIOS.
    >> --


    --
    ~Randy


    \
     
     \ /
      Last update: 2012-04-17 00:27    [W:2.431 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site