lkml.org 
[lkml]   [2012]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] serial: 8250: Add cpufreq support
Date
On Thu, Apr 12, 2012 at 15:17:58, Alan Cox wrote:
> > > > I will have a look at this and add the lock if necessary.
> > >
> > > At the very least you need reference counts held on the tty struct and to allow for the tty having vanished under you.
> > >
> >
> > I am planning to add "tty->termios_mutex" lock. Any comments ?
>
> Explain how this will help. You need a reference count to the tty itself.
>


I have gone through the serial driver, still I am not able to figure out the requirement
of tty reference count here. Correct me if I am wrong.
As per my understanding, tty count keeps the count of tty_open and tty_release, that is
how many open and close happened on the tty device file(/dev/ttyS*).
The requirement here is a tty count check, if it is greater than zero then only it should
proceed for further execution.
Kindly elaborate more on the same if it's not correct.

>
> Alan
>



\
 
 \ /
  Last update: 2012-04-17 11:47    [W:0.791 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site