Messages in this thread |  | | | Date | Thu, 12 Apr 2012 10:47:58 +0100 | | From | Alan Cox <> | | Subject | Re: [PATCH] serial: 8250: Add cpufreq support |
| |
> > > I will have a look at this and add the lock if necessary. > > > > At the very least you need reference counts held on the tty struct and to allow for the tty having vanished under you. > > > > I am planning to add "tty->termios_mutex" lock. Any comments ?
Explain how this will help. You need a reference count to the tty itself.
> I understand this and planning to avoid unnecessary registration like these. > As a solution, UART port's cpu freq status will be sent from the board file. > Adding a member to the structure "plat_serial8250_port" which says whether > a port requires cpu freq registration or not. cpu freq register function is > called in the driver depending upon the status of this structure member. > I can update the patch accordingly and send out a version 2 to the list.
That sounds sensible.
Alan
|  |