lkml.org 
[lkml]   [2012]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subject3.0.23-rt39 BUG: scheduling while atomic, _cpu_down()
Hi Thomas,
(and Steve, since you've been mucking about in the hotplug code,)

Yet another bit of fallout related to hotplug.

This appears to affect 3.0-rt1, 3.0.23-rt29, and 3.2.9-rt17.
(Thus probably all 3.x versions, but I haven't been masochistic
enough to check.)

If not defined CONFIG_PREEMPT_RT_FULL then

- hotplug_lock() is a mutex_lock()
- cpu_hotplug_begin() calls hotplug_lock()
- _cpu_down() calls cpu_hotplug_begin() with preemption
disabled (disabled by the migrate_disable())

The call to cpu_hotplug_begin() is not in a preempt disabled
region until hotplug-use-migrate-disable.patch. This patch
moves the preempt_enable() (aka migrate_enable()) from just
before calling cpu_hotplug_begin() to after "out_cancel:".

The BUG can be triggered by:

echo 0 > /sys/devices/system/cpu/cpu1/online


-Frank



\
 
 \ /
  Last update: 2012-03-10 02:55    [W:0.045 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site