Messages in this thread | | | Date | Fri, 09 Mar 2012 09:57:33 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] x86: use enum instead of literals for trap values |
| |
On 03/09/2012 08:30 AM, Kees Cook wrote: > On Fri, Mar 9, 2012 at 1:28 AM, Ingo Molnar <mingo@elte.hu> wrote: >> >> * Kees Cook <keescook@chromium.org> wrote: >> >>> The traps are referred to by their numbers and it can be difficult to >>> understand them while reading the code without context. This patch adds >>> enumeration of the trap numbers and replaces the numbers with the correct >>> enum for x86. >>>
I have to admit personally to prefer something like X86_XCP_XX where XX is the two-letter code that the Intel documentation uses for that trap, i.e. #GP, #BR, #MC and so on.
-hpa
| |