Messages in this thread | | | Date | Fri, 9 Mar 2012 19:28:29 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH] x86: use enum instead of literals for trap values |
| |
On Fri, Mar 09, 2012 at 10:21:52AM -0800, Kees Cook wrote: > > I have to admit personally to prefer something like X86_XCP_XX where XX > > is the two-letter code that the Intel documentation uses for that trap, > > i.e. #GP, #BR, #MC and so on. > > We need a single person to decide on this bike shed color. :) If the > list of enum names can be agreed on, I'll be happy to do the > search/replace for it.
Well,
here are my 2¢: I agree with hpa because
a) it maps the CPU vendor documentation b) it is nicely short
Thanks.
-- Regards/Gruss, Boris.
Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |