Messages in this thread | | | From | Chris Wilson <> | Subject | Re: [PATCH 3/9] drm/i915/intel_i2c: refactor using intel_gmbus_get_bus | Date | Wed, 07 Mar 2012 12:15:18 +0000 |
| |
On Wed, 7 Mar 2012 19:50:44 +0800, Daniel Kurtz <djkurtz@chromium.org> wrote: > Instead of letting other modules directly access the ->gmbus array, > introduce a new API, intel_gmbus_get_bus(), to lookup an i2c_adapter for > a given gmbus pin pair identifier. This API enables later refactoring > of the gmbus pin pair list. > > Note: It is critical that intel_setup_gmbus() gets called before > intel_gmbus_get_bus().
If you are going to rename it, perhaps a better choice than intel_gmbus_get_bus(int gpio_pin) ?
intel_i2c_get_adapter(int gpio_pin) since the rest of the code really does not care how the bits are transferred but that it interfaces using i2c. -Chris
-- Chris Wilson, Intel Open Source Technology Centre
| |