Messages in this thread | | | From | Chris Wilson <> | Subject | Re: [PATCH 9/9] drm/i915/intel_i2c: reuse GMBUS2 value from polling loop | Date | Wed, 07 Mar 2012 12:09:42 +0000 |
| |
On Wed, 7 Mar 2012 19:50:50 +0800, Daniel Kurtz <djkurtz@chromium.org> wrote: > Save the GMBUS2 value read while polling for state changes, and then > reuse this value when determining for which reason the loops were exited. > This is a small optimization which saves a couple of bus accesses for > memory mapped IO registers. > > Note: checkpatch doesn't like this ('assigning in if condition'), but it seems > like the cleanest implementation. > > Signed-off-by: Daniel Kurtz <djkurtz@chromium.org> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> -Chris
-- Chris Wilson, Intel Open Source Technology Centre
| |