lkml.org 
[lkml]   [2012]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    SubjectRE: [PATCH 1/2] regulator: ad5398: show changing current in uA
    Acked-by: Sonic Zhang <sonic.zhang@analog.com>

    -----Original Message-----
    From: Axel Lin [mailto:axel.lin@gmail.com]
    Sent: Tuesday, March 27, 2012 10:08 AM
    To: linux-kernel@vger.kernel.org
    Cc: Zhang, Sonic; Liam Girdwood; Mark Brown
    Subject: [PATCH 1/2] regulator: ad5398: show changing current in uA

    Integer division may truncate the result.
    Current code shows changing current is 0mA when selector is 1 ... 8.

    For example:
    selector = 1
    ad5398_calc_current returns 117, debug message shows 117/1000 = 0mA
    selector = 2
    ad5398_calc_current returns 234, debug message shows 234/1000 = 0mA
    selector = 3
    ad5398_calc_current returns 351, debug message shows 351/1000 = 0mA
    ............
    selector = 8
    ad5398_calc_current returns 937, debug message shows 937/1000 = 0mA

    Show the changing current in uA makes it easier for debugging.

    Signed-off-by: Axel Lin <axel.lin@gmail.com>
    ---
    drivers/regulator/ad5398.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/regulator/ad5398.c b/drivers/regulator/ad5398.c
    index 26d23ad..ed58798 100644
    --- a/drivers/regulator/ad5398.c
    +++ b/drivers/regulator/ad5398.c
    @@ -99,8 +99,8 @@ static int ad5398_set_current_limit(struct regulator_dev *rdev, int min_uA, int
    if (ad5398_calc_current(chip, selector) > max_uA)
    return -EINVAL;

    - dev_dbg(&client->dev, "changing current %dmA\n",
    - ad5398_calc_current(chip, selector) / 1000);
    + dev_dbg(&client->dev, "changing current %duA\n",
    + ad5398_calc_current(chip, selector));

    /* read chip enable bit */
    ret = ad5398_read_reg(client, &data);
    --
    1.7.5.4




    \
     
     \ /
      Last update: 2012-03-27 05:05    [W:0.025 / U:1.920 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site