lkml.org 
[lkml]   [2012]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Date
Subject[PATCH] list_debug: WARN for adding something already in the list
We were bitten by this at one point and added an additional sanity
test for DEBUG_LIST. You can't validly add a list_head to a list
where either prev or next is the same as the thing you're adding.

Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
---
lib/list_debug.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/lib/list_debug.c b/lib/list_debug.c
index b8029a5..ee41bd2 100644
--- a/lib/list_debug.c
+++ b/lib/list_debug.c
@@ -28,6 +28,9 @@ void __list_add(struct list_head *new,
"list_add corruption. prev->next should be "
"next (%p), but was %p. (prev=%p).\n",
next, prev->next, prev);
+ WARN(new == prev || new == next,
+ "list_add double add: new=%p, prev=%p, next=%p.\n",
+ new, prev, next);
next->prev = new;
new->next = next;
new->prev = prev;
--
1.6.5.2


\
 
 \ /
  Last update: 2012-03-26 22:53    [W:0.116 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site