Messages in this thread Patch in this message | | | Date | Fri, 2 Mar 2012 09:54:41 +0300 | From | Dan Carpenter <> | Subject | [patch] edac i5000: fix pointer math in i5000_get_mc_regs() |
| |
"pvt->ambase" is a u64 datatype. The intent here is to fill the first half in the first call to pci_read_config_dword() and the other half in the second. Unfortunately the pointer math is wrong so we set the wrong data.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- I don't have the hardware to test this. Please review carefully.
diff --git a/drivers/edac/i5000_edac.c b/drivers/edac/i5000_edac.c index 4dc3ac2..fcdc4ab 100644 --- a/drivers/edac/i5000_edac.c +++ b/drivers/edac/i5000_edac.c @@ -1130,7 +1130,7 @@ static void i5000_get_mc_regs(struct mem_ctl_info *mci) pci_read_config_dword(pvt->system_address, AMBASE, (u32 *) & pvt->ambase); pci_read_config_dword(pvt->system_address, AMBASE + sizeof(u32), - ((u32 *) & pvt->ambase) + sizeof(u32)); + (u32 *)((char *) &pvt->ambase + sizeof(u32))); maxdimmperch = pvt->maxdimmperch; maxch = pvt->maxch;
| |