Messages in this thread | | | From | "Turquette, Mike" <> | Date | Mon, 19 Mar 2012 12:53:50 -0700 | Subject | Re: [PATCH v7 2/3] clk: introduce the common clock framework |
| |
On Mon, Mar 19, 2012 at 4:22 AM, Rajendra Nayak <rnayak@ti.com> wrote: > On Friday 16 March 2012 11:41 AM, Mike Turquette wrote: >> +/* >> + * calculate the new rates returning the topmost clock that has to be >> + * changed. >> + */ >> +static struct clk *clk_calc_new_rates(struct clk *clk, unsigned long >> rate) >> +{ >> + struct clk *top = clk; >> + unsigned long best_parent_rate = clk->parent->rate; > > > Shouldn't you check for a valid parent before dereferencing it? A > clk_set_rate() on a root clock might throw up some issues otherwise.
Yes, the clk_calc_new_rates code assumes a valid parent pointer in several locations. Thanks for the catch. Will roll into my fixes series.
Regards, Mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |