lkml.org 
[lkml]   [2012]   [Mar]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v7 2/3] clk: introduce the common clock framework
    Another trivial comment.  But if there is an incremental patch, maybe
    consider to include it.

    On Thu, Mar 15, 2012 at 11:11:19PM -0700, Mike Turquette wrote:
    ...
    > +#ifdef CONFIG_COMMON_CLK_DISABLE_UNUSED
    > +static int clk_disable_unused(void)
    > +{
    > + struct clk *clk;
    > + struct hlist_node *tmp;
    > +
    > + mutex_lock(&prepare_lock);
    > +
    > + hlist_for_each_entry(clk, tmp, &clk_root_list, child_node)
    > + clk_disable_unused_subtree(clk);
    > +
    > + hlist_for_each_entry(clk, tmp, &clk_orphan_list, child_node)
    > + clk_disable_unused_subtree(clk);
    > +
    > + mutex_unlock(&prepare_lock);
    > +
    > + return 0;
    > +}
    > +late_initcall(clk_disable_unused);
    > +#else
    > +static inline int clk_disable_unused(struct clk *clk) { return 0; }

    This #else block seems completely unnecessary to me.

    > +#endif /* CONFIG_COMMON_CLK_DISABLE_UNUSED */

    --
    Regards,
    Shawn


    \
     
     \ /
      Last update: 2012-03-18 15:09    [W:0.023 / U:1.508 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site