lkml.org 
[lkml]   [2012]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next] net: ipv4: Standardize prefixes for message logging
From
From: Joe Perches <joe@perches.com>
Date: Mon, 12 Mar 2012 10:03:32 -0700

> Add #define pr_fmt(fmt) as appropriate.
>
> Add "IPv4: ", "TCP: ", and "IPsec: " to appropriate files.
> Standardize on "UDPLite: " for appropriate uses.
> Some prefixes were previously "UDPLITE: " and "UDP-Lite: ".
>
> Add KBUILD_MODNAME ": " to icmp and gre.
> Remove embedded prefixes as appropriate.
>
> Add missing "\n" to pr_info in gre.c.
>
> Signed-off-by: Joe Perches <joe@perches.com>

Looks good, and applied, but I left out this hunk:

> diff --git a/net/ipv4/ipcomp.c b/net/ipv4/ipcomp.c
> index 63b64c4..56d6768 100644
> --- a/net/ipv4/ipcomp.c
> +++ b/net/ipv4/ipcomp.c
> @@ -13,6 +13,7 @@
> * - Compression stats.
> * - Adaptive compression.
> */
> +
> #include <linux/module.h>
> #include <linux/err.h>
> #include <linux/rtnetlink.h>

As it seemed accidental, if not gratuitous.


\
 
 \ /
  Last update: 2012-03-13 01:09    [W:2.053 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site