Messages in this thread | | | Date | Sun, 11 Mar 2012 23:48:46 -0700 (PDT) | Subject | Re: [PATCH net-next] net: Convert printks to pr_<level> | From | David Miller <> |
| |
From: Joe Perches <joe@perches.com> Date: Sun, 11 Mar 2012 21:36:11 -0700
> Use a more current kernel messaging style. > > Convert a printk block to print_hex_dump. > Coalesce formats, align arguments. > Use %s, __func__ instead of embedding function names. > > Some messages that were prefixed with <foo>_close are > now prefixed with <foo>_fini. Some ah4 and esp messages > are now not prefixed with "ip ". > > The intent of this patch is to later add something like > #define pr_fmt(fmt) "IPv4: " fmt. > to standardize the output messages. > > Text size is trivially reduced. (x86-32 allyesconfig) > > $ size net/ipv4/built-in.o* > text data bss dec hex filename > 887888 31558 249696 1169142 11d6f6 net/ipv4/built-in.o.new > 887934 31558 249800 1169292 11d78c net/ipv4/built-in.o.old > > Signed-off-by: Joe Perches <joe@perches.com>
Applied, thanks a lot Joe.
| |