lkml.org 
[lkml]   [2012]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next] net: Convert printks to pr_<level>
From
From: Joe Perches <joe@perches.com>
Date: Sun, 11 Mar 2012 21:36:11 -0700

> Use a more current kernel messaging style.
>
> Convert a printk block to print_hex_dump.
> Coalesce formats, align arguments.
> Use %s, __func__ instead of embedding function names.
>
> Some messages that were prefixed with <foo>_close are
> now prefixed with <foo>_fini. Some ah4 and esp messages
> are now not prefixed with "ip ".
>
> The intent of this patch is to later add something like
> #define pr_fmt(fmt) "IPv4: " fmt.
> to standardize the output messages.
>
> Text size is trivially reduced. (x86-32 allyesconfig)
>
> $ size net/ipv4/built-in.o*
> text data bss dec hex filename
> 887888 31558 249696 1169142 11d6f6 net/ipv4/built-in.o.new
> 887934 31558 249800 1169292 11d78c net/ipv4/built-in.o.old
>
> Signed-off-by: Joe Perches <joe@perches.com>

Applied, thanks a lot Joe.


\
 
 \ /
  Last update: 2012-03-12 07:51    [W:0.284 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site