[lkml]   [2012]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [RFC][PATCH 00/50] set addr_assign_type to NET_ADDR_RANDOM if a random mac address get assigned to a netdevice
    On Donnerstag, 9. Februar 2012, David Miller wrote:
    > 50 patches is way too many patches to submit and expect people
    > to review at one time.
    > You must do one of two things:
    > 1) Condense the series down to a smaller number of more managable
    > patches. Perhaps combine all the completely trivial conversion
    > cases into one single patch, and post the non-trivial cases
    > seperately.
    > 2) Only submit a few of these changes at a time, not all at once.
    > It's your choice, but what you did here is unacceptable.

    Could you at least comment on these points from the cover letter, before I
    change/update the patches?

    - Should NET_ADDR_RANDOM get reset (to NET_ADDR_PERM) if the MAC address
    get changed via SIOCSIFHWADDR/.ndo_set_mac_address and was random before?
    - Would it make sense to add a new state (e.g. NET_ADDR_USERSPACE)
    if the net address get changed via SIOCSIFHWADDR/.ndo_set_mac_address
    from userspace?



     \ /
      Last update: 2012-02-09 13:21    [W:0.021 / U:16.540 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site