lkml.org 
[lkml]   [2012]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 01/50] eth: reset addr_assign_type if eth_mac_addr() called
Date
On Mittwoch, 8. Februar 2012, Stephen Hemminger wrote:
> On Wed, 8 Feb 2012 22:10:08 +0100
>
> Danny Kukawka <danny.kukawka@bisect.de> wrote:
> > + if (dev->addr_assign_type & NET_ADDR_RANDOM)
> > + dev->addr_assign_type ^= NET_ADDR_RANDOM;
>
> Why not just avoid the conditional, or better yet use bitops?
>
> dev->addr_assign_type &= ~NET_ADDR_RANDOM;

Okay, If I have comments on the other patches back, I will send new versions
which avoid the if. Thanks for the hint.

Danny



\
 
 \ /
  Last update: 2012-02-09 00:01    [from the cache]
©2003-2011 Jasper Spaans