Messages in this thread | | | From | Danny Kukawka <> | Subject | Re: [PATCH 12/12] rose: check given MAC address, if invalid return -EADDRNOTAVAIL | Date | Sat, 25 Feb 2012 19:25:28 +0100 |
| |
On Freitag, 24. Februar 2012, David Miller wrote: > From: Alan Cox <alan@lxorguk.ukuu.org.uk> > Date: Fri, 24 Feb 2012 16:13:58 +0000 > > > On Fri, 24 Feb 2012 17:01:22 +0100 > > > > Danny Kukawka <danny.kukawka@bisect.de> wrote: > >> Check if given address is valid in .ndo_set_mac_address/ > >> rose_set_mac_address(), if invalid return -EADDRNOTAVAIL as > >> eth_mac_addr() already does if is_valid_ether_addr() fails. > > > > This patch series looks wrong - you cannot go blindly applying ethernet > > mac address tests to device drivers without checking if they are using > > 802.11 type addressing at the physical level.
Overseen this aspect ... Sorry. I'll check the patches and send an updated version.
Do you mean 802.3 ?
Danny
| |