[lkml]   [2012]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 12/12] rose: check given MAC address, if invalid return -EADDRNOTAVAIL
    On Fri, 24 Feb 2012 17:01:22 +0100
    Danny Kukawka <> wrote:

    > Check if given address is valid in .ndo_set_mac_address/
    > rose_set_mac_address(), if invalid return -EADDRNOTAVAIL as
    > eth_mac_addr() already does if is_valid_ether_addr() fails.

    This patch series looks wrong - you cannot go blindly applying ethernet
    mac address tests to device drivers without checking if they are using
    802.11 type addressing at the physical level.


     \ /
      Last update: 2012-02-24 17:15    [W:0.029 / U:67.564 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site