lkml.org 
[lkml]   [2012]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3 v2] Staging: crystalhd: Replace the BCMLOG_ERR macro with pr_err
On Sat, Feb 18, 2012 at 08:10:20PM -0200, Jorgyano Vieira wrote:
> Replace the usage of BCMLOG_ERR with pr_err and remove the macro definition.
> Also added pr_fmt to identify the driver error messages.
>
> Signed-ff-by: Jorgyano Vieira <jorgyano@gmail.com>
> ---
> drivers/staging/crystalhd/crystalhd_cmds.c | 68 ++++++++--------
> drivers/staging/crystalhd/crystalhd_hw.c | 119 ++++++++++++++--------------
> drivers/staging/crystalhd/crystalhd_lnx.c | 96 +++++++++++-----------
> drivers/staging/crystalhd/crystalhd_lnx.h | 4 +-
> drivers/staging/crystalhd/crystalhd_misc.c | 70 ++++++++--------
> drivers/staging/crystalhd/crystalhd_misc.h | 10 +--
> 6 files changed, 181 insertions(+), 186 deletions(-)
>
> diff --git a/drivers/staging/crystalhd/crystalhd_cmds.c b/drivers/staging/crystalhd/crystalhd_cmds.c
> index 3735ed3..46fac01 100644
> --- a/drivers/staging/crystalhd/crystalhd_cmds.c
> +++ b/drivers/staging/crystalhd/crystalhd_cmds.c
> @@ -75,12 +75,12 @@ static enum BC_STATUS bc_cproc_notify_mode(struct crystalhd_cmd *ctx,
> int rc = 0, i = 0;
>
> if (!ctx || !idata) {
> - BCMLOG_ERR("Invalid Arg!!\n");
> + pr_err("%s: Invalid Arg!!\n", __func__);

This is nice, but, as this is a driver, I really prefer the use of
dev_err() instead, which allows us to properly identify the device and
driver that spit out the error message. Care to redo this patch in that
style instead?

thanks,

greg k-h


\
 
 \ /
  Last update: 2012-02-24 20:59    [W:0.103 / U:0.604 seconds]
©2003-2014 Jasper Spaans. Advertise on this site