Messages in this thread | | | Subject | Re: [PATCH 3/3 v2] Staging: crystalhd: Replace the BCMLOG_ERR macro with pr_err | From | Joe Perches <> | Date | Sat, 18 Feb 2012 15:14:37 -0800 |
| |
On Sat, 2012-02-18 at 21:08 -0200, Jorgyano vieira wrote: > > o pr_fmt needs to be #defined before any #include that might > > directly or indirectly #include kernel.h/printk.h > > use 'strings <path>/built-in.o | grep "^<.>"' to verify. > yes, I take care of this:--- a/drivers/staging/crystalhd/crystalhd_misc.h > +++ b/drivers/staging/crystalhd/crystalhd_misc.h > @@ -28,6 +28,8 @@ > #ifndef _CRYSTALHD_MISC_H_ > #define _CRYSTALHD_MISC_H_ > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > +
Maybe.
$ grep -rP --include=*.[ch] -m1 "^[ \t]*#[ \t]*include" drivers/staging/crystalhd/ drivers/staging/crystalhd/crystalhd_cmds.h:#include "crystalhd_misc.h" drivers/staging/crystalhd/crystalhd_lnx.c:#include <linux/mutex.h> drivers/staging/crystalhd/crystalhd_cmds.c:#include "crystalhd_cmds.h" drivers/staging/crystalhd/bc_dts_types.h:#include <stdint.h> drivers/staging/crystalhd/bc_dts_glob_lnx.h:#include <stdio.h> drivers/staging/crystalhd/crystalhd_misc.c:#include <linux/slab.h> drivers/staging/crystalhd/crystalhd_misc.h:#include <linux/module.h> drivers/staging/crystalhd/crystalhd_lnx.h:#include <linux/module.h> drivers/staging/crystalhd/crystalhd_hw.h:#include "crystalhd_misc.h" drivers/staging/crystalhd/crystalhd_hw.c:#include <linux/pci.h>
so lnx, cmds, misc, and hw.c are/were suspect.
cheers, Joe
| |