lkml.org 
[lkml]   [2012]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH 01/14] sched: track the runnable average on a per-task entitiy basis
From
Date
On Wed, 2012-02-01 at 17:38 -0800, Paul Turner wrote:
> + /*
> + * Use 1024us as the unit of measurement since it's a reasonable
> + * approximation of 1ms and fast to compute.
> + */
> + delta >>= 10;

ns -> us ?, text talks about ms, slightly confusing

> + if (!delta)
> + return 0;
> + sa->last_runnable_update = now;
> +
> + delta_w = sa->runnable_avg_period % 1024;

so delta_w is the chunk of this p we already accounted.

> + if (delta + delta_w >= 1024) {

if delta pushes us over 1024*1024 ns (~1ms) we roll a window.

> + /* period roll-over */
> + decayed = 1;
> +
> + delta_w = 1024 - delta_w;

The distance we need to reach the next window.

> + BUG_ON(delta_w > delta);

somehow reading this code took forever, this suggests clarification,
either through better variable names or more comments. Could also mean
I'm a moron and should get more sleep or so :-)


\
 
 \ /
  Last update: 2012-02-16 00:39    [W:0.377 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site