Messages in this thread Patch in this message | | | Date | Tue, 28 Feb 2012 17:45:59 +0000 | From | Morten Rasmussen <> | Subject | Re: [PATCH 1/2] sched: entity load-tracking re-work - Fix for ARM |
| |
On Wed, Feb 29, 2012 at 10:37:38AM +0000, Pantelis Antoniou wrote: > @@ -1110,9 +1110,9 @@ static inline void __update_group_entity_contrib(struct sched_entity *se) > struct cfs_rq *cfs_rq = group_cfs_rq(se); > struct task_group *tg = cfs_rq->tg; > int runnable_avg; > + u64 contrib; > > - se->avg.load_avg_contrib = (cfs_rq->tg_load_contrib * tg->shares); > - se->avg.load_avg_contrib /= atomic64_read(&tg->load_avg) + 1;
It seems that contrib is never assigned? Fix: + contrib = (cfs_rq->tg_load_contrib * tg->shares);
> + se->avg.load_avg_contrib = div_u64(contrib, atomic64_read(&tg->load_avg) + 1);
Regards, Morten
| |