lkml.org 
[lkml]   [2012]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] bluetooth: Use more current logging styles
From
Date
Hi Joe,

> > Why is this a good thing?
>
> It's more similar to the rest of the <foo>_<level> uses.
> Other than that, it's a little smaller.
>
> > And in your patch we have bt_err not having \n\n in the end.
>
> There shouldn't be a newline at all with the
> actual functions bt_err or bt_info except
> at the uses.

then you might wanna read your patch again ;)

> This is the style used in pr_<level> so that
> it becomes possible to use pr_cont.

Since we don't have a bt_cont, I don't see why bother changing this
right now.

Regards

Marcel




\
 
 \ /
  Last update: 2012-02-13 08:27    [W:0.140 / U:0.904 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site