Messages in this thread | | | Subject | Re: [PATCH 1/2] bluetooth: Use more current logging styles | From | Marcel Holtmann <> | Date | Mon, 13 Feb 2012 08:21:46 +0100 |
| |
Hi Joe,
> > Why is this a good thing? > > It's more similar to the rest of the <foo>_<level> uses. > Other than that, it's a little smaller. > > > And in your patch we have bt_err not having \n\n in the end. > > There shouldn't be a newline at all with the > actual functions bt_err or bt_info except > at the uses.
then you might wanna read your patch again ;)
> This is the style used in pr_<level> so that > it becomes possible to use pr_cont.
Since we don't have a bt_cont, I don't see why bother changing this right now.
Regards
Marcel
| |