lkml.org 
[lkml]   [2012]   [Feb]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/5] ACPI: Do cpufreq clamping for throttling per package v2
On Mon, Feb 13, 2012 at 06:30:33PM -0500, Len Brown wrote:
> On 02/06/2012 11:31 AM, Matthew Garrett wrote:
>
> > On Mon, Feb 06, 2012 at 08:17:11AM -0800, Andi Kleen wrote:
> >> +#define reduction_pctg(cpu) \
> >> + per_cpu(cpufreq_thermal_reduction_pctg, phys_package_first_cpu(cpu))
> >
> > I don't like using percentages here - we end up with the potential for
> > several percentages to end up mapping to the same P state.
>
>
> Does it matter?

If you step through multiple percentages that map to the same P state,
yes. On the other hand, re-reading the specification, it seems that this
is the behaviour envisaged in the polling equation. I guess we'll stick
with that.

--
Matthew Garrett | mjg59@srcf.ucam.org


\
 
 \ /
  Last update: 2012-02-14 01:21    [W:1.206 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site