lkml.org 
[lkml]   [2012]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/5] ACPI: Do cpufreq clamping for throttling per package v2
On Mon, Feb 06, 2012 at 08:17:11AM -0800, Andi Kleen wrote:
> +#define reduction_pctg(cpu) \
> + per_cpu(cpufreq_thermal_reduction_pctg, phys_package_first_cpu(cpu))

I don't like using percentages here - we end up with the potential for
several percentages to end up mapping to the same P state. I've sent a
patch that replaces the percentage code with just stepping through P
states instead. But otherwise, yes, this seems sensible. An open
question is whether we should be doing the same on _PPC notifications.
There's some vague evidence that Windows does.

--
Matthew Garrett | mjg59@srcf.ucam.org

\
 
 \ /
  Last update: 2012-02-06 17:33    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site