Messages in this thread | | | Date | Wed, 7 Nov 2012 11:32:47 -0800 | Subject | Re: [PATCH] tcp: Replace infinite loop on recvmsg bug with proper crashusers | From | Julius Werner <> |
| |
I tend to agree with Dave that it's not in the user's best interest to have a full-on BUG() here, and that we can get our reports just as well by fishing them from the log through abrt or something similar. I will just submit my alternative patch too and let you decide which one you prefer.
This version shuts down the socket, so the broken receive queue will not be used again and eventually freed. Other sockets and the system as a whole will stay usable and probably still work if the bug is a very rare coincidence. Of course, the driver will still be buggy, but the same would stay true after a reboot (which is what most people do after a panic). The userland caller gets an unexpected error code, which is not the same as receiving a proper FIN and is the only thing we can do to communicate this.
| |