Messages in this thread | | | Subject | Re: [PATCH] tcp: Replace infinite loop on recvmsg bug with proper crashusers | From | Eric Dumazet <> | Date | Wed, 07 Nov 2012 08:29:12 -0800 |
| |
On Wed, 2012-11-07 at 10:54 -0500, Dave Jones wrote:
> It sounds more appropriate to me, instead of silently wedging the box. > At least with that approach we have a chance of finding out what happened.
Its quite the opposite.
If bug is still there 6 months after the commits that broke the drivers, (making an old bug visible) that means that people never realized the bug was there.
I understand a distro maintainer has its own choices, but for upstream kernel we want to have early reports.
This bug is fatal and a security issue. BUG() is appropriate.
If the driver cant be fixed, it should be marked broken.
So I personally NACKed patch to hide the bug, trying to be friendly to the user.
| |