lkml.org 
[lkml]   [2012]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] perf tools: Introduce struct hist_browser_timer
On 11/1/12 11:50 PM, Namhyung Kim wrote:
> From: Namhyung Kim <namhyung.kim@lge.com>
>
> Currently various hist browser functions receive 3 arguments for
> refreshing histogram but only used from a few places. Also it's only
> for perf top command so that it can be NULL for other (and probably
> most) cases. Pack them into a struct in order to reduce number of
> those unused arguments.
>
> This is a mechanical change and does not intend a functional change.
>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Irina Tirdea <irina.tirdea@gmail.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
> tools/perf/builtin-annotate.c | 2 +-
> tools/perf/builtin-report.c | 4 ++--
> tools/perf/builtin-top.c | 9 +++++---
> tools/perf/ui/browsers/annotate.c | 27 +++++++++++-------------
> tools/perf/ui/browsers/hists.c | 43 +++++++++++++++++----------------------
> tools/perf/ui/gtk/browser.c | 4 +---
> tools/perf/util/annotate.h | 8 ++++----
> tools/perf/util/hist.h | 28 ++++++++++++-------------
> 8 files changed, 58 insertions(+), 67 deletions(-)

Tested-by: David Ahern <dsahern@gmail.com>



\
 
 \ /
  Last update: 2012-11-05 20:21    [W:0.182 / U:0.696 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site