Messages in this thread | | | Date | Mon, 05 Nov 2012 08:25:35 -0700 | From | David Ahern <> | Subject | Re: [PATCH 3/3] perf report: Postpone objdump check until annotation requested |
| |
On 11/1/12 11:50 PM, Namhyung Kim wrote: > From: Namhyung Kim <namhyung.kim@lge.com> > > David reported that current perf report refused to run on a data file > captured from a different machine because of objdump. Since the > objdump tools won't be used unless annotation was requested, checking > its presence at init time doens't make sense. > > Reported-by: David Ahern <dsahern@gmail.com> > Cc: Irina Tirdea <irina.tirdea@gmail.com> > Signed-off-by: Namhyung Kim <namhyung@kernel.org> > --- > tools/perf/builtin-report.c | 9 ++------- > tools/perf/builtin-top.c | 3 ++- > tools/perf/ui/browsers/hists.c | 22 ++++++++++++++++------ > tools/perf/util/hist.h | 7 +++++-- > 4 files changed, 25 insertions(+), 16 deletions(-)
Reviewed-by/Tested-by: David Ahern <dsahern@gmail.com>
| |