lkml.org 
[lkml]   [2012]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] perf report: Postpone objdump check until annotation requested
On 11/1/12 11:50 PM, Namhyung Kim wrote:
> From: Namhyung Kim <namhyung.kim@lge.com>
>
> David reported that current perf report refused to run on a data file
> captured from a different machine because of objdump. Since the
> objdump tools won't be used unless annotation was requested, checking
> its presence at init time doens't make sense.
>
> Reported-by: David Ahern <dsahern@gmail.com>
> Cc: Irina Tirdea <irina.tirdea@gmail.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
> tools/perf/builtin-report.c | 9 ++-------
> tools/perf/builtin-top.c | 3 ++-
> tools/perf/ui/browsers/hists.c | 22 ++++++++++++++++------
> tools/perf/util/hist.h | 7 +++++--
> 4 files changed, 25 insertions(+), 16 deletions(-)

Reviewed-by/Tested-by: David Ahern <dsahern@gmail.com>




\
 
 \ /
  Last update: 2012-11-05 17:21    [W:0.074 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site