Messages in this thread Patch in this message | | | From | Constantine Shulyupin <> | Subject | [PATCH] checkpatch: debugfs_remove() can take NULL | Date | Sat, 17 Nov 2012 14:33:01 +0200 |
| |
From: Constantine Shulyupin <const@MakeLinux.com>
debugfs_remove() can take a NULL, so let's check and warn about that.
Signed-off-by: Constantine Shulyupin <const@MakeLinux.com> --- scripts/checkpatch.pl | 8 ++++++++ 1 file changed, 8 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index f18750e..c062476 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3221,6 +3221,14 @@ sub process { "kfree(NULL) is safe this check is probably not required\n" . $hereprev); } } +# check for needless debugfs_remove() checks + if ($prevline =~ /\bif\s*\(([^\)]*)\)/) { + my $expr = $1; + if ($line =~ /\bdebugfs_remove\(\Q$expr\E\);/) { + WARN("NEEDLESS_DEBUGFS_REMOVE", + "debugfs_remove(NULL) is safe this check is probably not required\n" . $hereprev); + } + } # check for needless usb_free_urb() checks if ($prevline =~ /\bif\s*\(([^\)]*)\)/) { my $expr = $1; -- 1.7.9.5
| |