lkml.org 
[lkml]   [2012]   [Oct]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subjectre: sched, numa, mm: Implement constant, per task Working Set Sampling (WSS) rate
Hello Peter Zijlstra,

The patch 3d049f8a5398: "sched, numa, mm: Implement constant, per
task Working Set Sampling (WSS) rate" from Oct 14, 2012, leads to the
following warning:
kernel/sched/fair.c:954 task_numa_work()
error: we previously assumed 'vma' could be null (see line 948)

943 if (!vma) {
944 ACCESS_ONCE(mm->numa_scan_seq)++;
945 offset = 0;
946 vma = mm->mmap;
947 }
948 while (vma && !vma_migratable(vma)) {
^^^
If this is NULL,
949 vma = vma->vm_next;
950 if (!vma)
951 goto again;
952 }
953
954 offset = max(offset, vma->vm_start);
^^^^^^^^^^^^^
then it leads to a NULL dereference here.

regards,
dan carpenter



\
 
 \ /
  Last update: 2012-10-22 14:41    [W:0.103 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site