Messages in this thread | | | Date | Tue, 2 Oct 2012 06:58:42 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH v3 -tip 2/5] x86, MSI: Allocate as many multiple IRQs as requested |
| |
* Alexander Gordeev <agordeev@redhat.com> wrote:
> When multiple MSIs are enabled with pci_enable_msi_block() the number of > allocated IRQs 'nvec' is rounded up to the nearest value of power of two. > That could lead to a condition when number of requested and used IRQs is > less than number of actually allocated IRQs. > > This fix introduces 'msi_desc::nvec' field to address the above issue - > when non-zero, it holds the number of allocated IRQs. Otherwise, the old > method is used. > > Signed-off-by: Alexander Gordeev <agordeev@redhat.com> > --- > arch/x86/kernel/apic/io_apic.c | 16 +++++++--------- > drivers/pci/msi.c | 10 ++++++++-- > include/linux/msi.h | 1 + > 3 files changed, 16 insertions(+), 11 deletions(-)
This should be switched with the first patch: first extend the generic MSI code, then add x86 support for that variant.
Adding multi-MSI support in one patch then tweaking it in the very next patch makes little sense and cannot possibly have been tested much so it's a potential bisection trap.
Thanks,
Ingo
| |