lkml.org 
[lkml]   [2012]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 -tip 2/5] x86, MSI: Allocate as many multiple IRQs as requested

* Alexander Gordeev <agordeev@redhat.com> wrote:

> When multiple MSIs are enabled with pci_enable_msi_block() the number of
> allocated IRQs 'nvec' is rounded up to the nearest value of power of two.
> That could lead to a condition when number of requested and used IRQs is
> less than number of actually allocated IRQs.
>
> This fix introduces 'msi_desc::nvec' field to address the above issue -
> when non-zero, it holds the number of allocated IRQs. Otherwise, the old
> method is used.
>
> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> ---
> arch/x86/kernel/apic/io_apic.c | 16 +++++++---------
> drivers/pci/msi.c | 10 ++++++++--
> include/linux/msi.h | 1 +
> 3 files changed, 16 insertions(+), 11 deletions(-)

This should be switched with the first patch: first extend the
generic MSI code, then add x86 support for that variant.

Adding multi-MSI support in one patch then tweaking it in the
very next patch makes little sense and cannot possibly have been
tested much so it's a potential bisection trap.

Thanks,

Ingo


\
 
 \ /
  Last update: 2012-10-02 07:41    [W:1.444 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site