Messages in this thread | | | Date | Tue, 02 Oct 2012 12:45:26 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH v3 -tip 5/5] AHCI: Support multiple MSIs |
| |
On 10/02/2012 12:42 PM, Alexander Gordeev wrote: > On Tue, Oct 02, 2012 at 07:09:29AM +0200, Ingo Molnar wrote: >>> +irqreturn_t ahci_hw_interrupt(int irq, void *dev_instance) >>> +{ >>> + struct ata_port *ap_this = dev_instance; >>> + struct ahci_port_priv *pp = ap_this->private_data; >>> + struct ata_host *host = ap_this->host; >>> + struct ahci_host_priv *hpriv = host->private_data; >>> + void __iomem *mmio = hpriv->mmio; >>> + unsigned int i; >>> + u32 irq_stat, irq_masked; >>> + >>> + VPRINTK("ENTER\n"); >> >> Is this per IRQ handler execution debugging code still needed? >> Same for the other VPRINTK() lines in this patch. > > These VPRINKs are only to make new handlers look like ahci_interrupt() > which did not change. I believe, if they need to go it is better to > remove them altogether, with a separate followup patch.
Definitely followup patch material + discussion :)
For the moment, the above is consistent with existing code, and by default compiled out, as one would expect.
Jeff
| |