Messages in this thread Patch in this message | | | Date | Thu, 18 Oct 2012 16:00:03 -0700 (PDT) | From | Dan Magenheimer <> | Subject | cancel_delayed_work() semantics broken? |
| |
Hi Tejun --
Forgive me if I am missing something, but it appears that your commit: 57b30ae77bf00d2318df711ef9a4d2a9be0a3a2a (workqueue: reimplement cancel_delayed_work() using try_to_grab_pending()) has subtly broken the semantics of the function. If work was idle, according to the comment, it should return false, correct?
It appears that very few callsites check the return value, but ramster does, as does ocfs2 from whence the code at the ramster callsite was derived. They both decrement a kref count based on the return value.
I am still looking at try_to_grab_pending as I am not sure if its semantics have also changed.
Thanks, Dan
Signed-off-by: Dan Magenheimer <dan.magenheimer@oracle.com>
diff --git a/kernel/workqueue.c b/kernel/workqueue.c index d951daa..042d221 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -2982,7 +2982,7 @@ bool cancel_delayed_work(struct delayed_work *dwork) set_work_cpu_and_clear_pending(&dwork->work, work_cpu(&dwork->work)); local_irq_restore(flags); - return true; + return ret; } EXPORT_SYMBOL(cancel_delayed_work);
| |