lkml.org 
[lkml]   [2012]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] msi: fix imbalanced refcount of msi irq sysfs objects
On Wed, Jan 04, 2012 at 09:19:52AM -0800, Jesse Barnes wrote:
> On Tue, 3 Jan 2012 13:53:05 -0500
> Neil Horman <nhorman@tuxdriver.com> wrote:
>
> > On Tue, Jan 03, 2012 at 01:05:26PM -0500, David Miller wrote:
> > > From: Neil Horman <nhorman@tuxdriver.com>
> > > Date: Tue, 3 Jan 2012 10:29:54 -0500
> > >
> > > > This warning was recently reported to me:
> > >
> > > I've hit this too, see:
> > >
> > > http://marc.info/?l=linux-kernel&m=132458146927890&w=2
> > >
> > > and my analysis at:
> > >
> > > http://marc.info/?l=linux-arch&m=132458391128660&w=2
> > >
> > Yup, your analysis is correct. Regardless of the why behind msi enablement
> > failing, we need to gate the kobject_del/put in free_msi_irqs on successful
> > completion of kobject_init_and_add in populate_msi_sysfs. This patch does that,
> > using the parent pointer as a flag.
>
> I applied this to my -next branch; doesn't seem critical to land
> immediately. If you disagree let me know and I'll pull it over to my
> for-linus branch instead.
>
> Thanks,
I'm ok with it waiting, but I'll defer to Dave and others who have seen it
occur. It sounds like its alot of log noise.
Neil

> --
> Jesse Barnes, Intel Open Source Technology Center




\
 
 \ /
  Last update: 2012-01-04 20:53    [W:1.303 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site