lkml.org 
[lkml]   [2012]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] msi: fix imbalanced refcount of msi irq sysfs objects
On Tue, Jan 03, 2012 at 01:05:26PM -0500, David Miller wrote:
> From: Neil Horman <nhorman@tuxdriver.com>
> Date: Tue, 3 Jan 2012 10:29:54 -0500
>
> > This warning was recently reported to me:
>
> I've hit this too, see:
>
> http://marc.info/?l=linux-kernel&m=132458146927890&w=2
>
> and my analysis at:
>
> http://marc.info/?l=linux-arch&m=132458391128660&w=2
>
Yup, your analysis is correct. Regardless of the why behind msi enablement
failing, we need to gate the kobject_del/put in free_msi_irqs on successful
completion of kobject_init_and_add in populate_msi_sysfs. This patch does that,
using the parent pointer as a flag.

Thanks
Neil



\
 
 \ /
  Last update: 2012-01-03 19:55    [W:0.581 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site