Messages in this thread | | | Date | Tue, 31 Jan 2012 11:17:34 +0100 | From | Wolfram Sang <> | Subject | Re: [PATCH 1/3] platform: add common resource requesting and mapping helper |
| |
On Tue, Jan 31, 2012 at 06:00:00PM +0800, Barry Song wrote: > From: Barry Song <Baohua.Song@csr.com> > > this patch helps to move the common pattern from > > " > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > if (!res) { > ret = -ENODEV; > goto err; > }
You don't need to do the error checking for 'res'. You can simply do
res = platform_get_resource(pdev, IORESOURCE_MEM, 0); base = devm_request_and_ioremap(&dev->dev, res);
devm_request_and_ioremap() will check res. Given that, I don't think we can save a lot with another wrapper.
Thanks,
Wolfram
-- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |