Messages in this thread | | | From | Barry Song <> | Date | Wed, 1 Feb 2012 10:22:00 +0800 | Subject | Re: [PATCH 1/3] platform: add common resource requesting and mapping helper |
| |
Linus,
2012/2/1 Linus Walleij <linus.walleij@linaro.org>: > On Tue, Jan 31, 2012 at 11:00 AM, Barry Song <Barry.Song@csr.com> wrote: > >> From: Barry Song <Baohua.Song@csr.com> >> >> this patch helps to move the common pattern from > > Good idea! > >> @@ -44,6 +44,7 @@ extern struct device platform_bus; >> >> extern void arch_setup_pdev_archdata(struct platform_device *); >> extern struct resource *platform_get_resource(struct platform_device *, unsigned int, unsigned int); >> +extern void __iomem *platform_devm_request_and_ioremap(struct platform_device *, unsigned int); > > But don't you want a reverse call for the module remove() function? > > Like: > > extern void __iomem *platform_devm_iounmap_and_free(struct > platform_device *, unsigned int);
that point is we have the garbage collection mechanism by calling devm_ function families. everything is undone on driver detach. so we will not have the free and unmap things. > > ? > > Yours, > Linus Walleij
-barry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |