Messages in this thread | | | Date | Mon, 30 Jan 2012 16:34:27 +0100 | From | Wolfram Sang <> | Subject | Re: [RFC 2/2] regmap: make use of cached entries in debugfs |
| |
On Mon, Jan 30, 2012 at 02:56:28PM +0000, Mark Brown wrote: > On Mon, Jan 30, 2012 at 03:08:17PM +0100, Wolfram Sang wrote: > > > - if (!regmap_readable(map, i)) > > + if (map->cache_type == REGCACHE_NONE && !regmap_readable(map, i)) > > This isn't quite what you said in the changelog
Sorry, I reread and can't find the diff?
> and isn't going to play nicely with sparse register maps
sparse == RBTREE? What does "play nicely" mean here? Too slow?
> - it should be > > if (regmap_cached(map, i) || regmap_readable(map, i)) > > or so (regmap_cached() doesn't exist at present but it seems reasonable > that it should).
Sigh, I have to give up for now. Sadly, I am already way beyond my schedule regarding the amplifier driver and need to work on other things now.
Thanks,
Wolfram
-- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |